Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [#26] NavigationBar 백그라운드 수정 #27

Merged
merged 7 commits into from
Jan 8, 2024
Merged

Fix [#26] NavigationBar 백그라운드 수정 #27

merged 7 commits into from
Jan 8, 2024

Conversation

kim-seonwoo
Copy link
Member

@kim-seonwoo kim-seonwoo commented Jan 7, 2024 •
edited
Loading

👾 작업 내용

  • point 사진이 어느정도 확정된 것 같아서 추가하였습니다.
  • gray3 컬러 배경 관련하여 분기 처리 하여 배경색을 설정하도록 하였습니다.
    private func configureNavigationBar() {
        self.backgroundColor = isGray ? .gray7 : .background
    }
  • isGray의 추가로 파라미터가 증가하였습니다. bool값을 이용하여 설정합니다.
    init(leftItem type: NavigationBarType,
         isBackButton: Bool,
         isTitleLabel: Bool,
         isPointImage: Bool,
         isBackGroundGray: Bool,
         titleText: String? = nil)
  • 다음과 같이 UIScreen extension에 있는 isLongerThan812pt를 이용하여 SE와 그 이외 기기에 대한 분기 처리를 하였습니다.
        if UIScreen.main.isLongerThan812pt {

🚀 PR Point

  • 파라미터 줄바꿈 처리를 했는데 괜찮을지요?
  • 꿀코드 정보 드리겠습니다.
  • 다음과 같이 찍어보면 기기별 상태바의 픽셀을 파악할 수 있습니다!
            print(UIApplication.shared.windows.first?.windowScene?.statusBarManager?.statusBarFrame.height)
  • 참고로 SE는 20이고, 13mini경우 50입니다.

✅ Issue

Resolved #26

@kim-seonwoo kim-seonwoo added 😎선우 선우의 issue 🐞fix 오류 고치는 것 / 수정용 labels Jan 7, 2024
@kim-seonwoo kim-seonwoo added this to the 🚀1차 스프린트🚀 milestone Jan 7, 2024
@kim-seonwoo kim-seonwoo self-assigned this Jan 7, 2024
@kim-seonwoo kim-seonwoo linked an issue Jan 7, 2024 that may be closed by this pull request
[Fix] 커스텀 네비바 백그라운드 컬러 설정 #26
Closed
@Zoe0929 Zoe0929 self-requested a review January 7, 2024 08:20
@kim-seonwoo kim-seonwoo requested a review from boyeon0119 January 7, 2024 08:20
Zoe0929
Zoe0929 approved these changes Jan 8, 2024
View reviewed changes
HMH_iOS/HMH_iOS/Presentation/Common/UIComponets/HMHNavigationBar.swift
Comment on lines +47 to +52
init(leftItem type: NavigationBarType,
isBackButton: Bool,
isTitleLabel: Bool,
isPointImage: Bool,
isBackGroundGray: Bool,
titleText: String? = nil) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P5. 가독성이 훨씬 좋아진 것 같아요 좋아요!

boyeon0119
boyeon0119 approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@boyeon0119 boyeon0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5. 아주 나이스합니다~

@kim-seonwoo kim-seonwoo merged commit 359a7e5 into develop Jan 8, 2024
@kim-seonwoo kim-seonwoo deleted the fix/#26-NavigationBar branch January 9, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zoe0929 Zoe0929 Zoe0929 approved these changes

@boyeon0119 boyeon0119 boyeon0119 approved these changes

Assignees

@kim-seonwoo kim-seonwoo

Labels
🐞fix 오류 고치는 것 / 수정용 😎선우 선우의 issue
Projects
HMH-iOS AppJam Team Plan
Status: Done
Milestone
🚀1차 스프린트🚀
Development

Successfully merging this pull request may close these issues.

[Fix] 커스텀 네비바 백그라운드 컬러 설정
3 participants
@kim-seonwoo @Zoe0929 @boyeon0119